Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/legacy interopt/token from url #2574

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Conversation

eikeland
Copy link
Contributor

Updated Files:

  • packages/react/legacy-interopt/src/create-fusion-context.ts
  • packages/react/legacy-interopt/src/create-service-resolver.ts

Changes:

  1. create-fusion-context.ts
    • Added a call to authContainer.handleWindowCallbackAsync() before initializing TelemetryLogger.
const authContainer = new LegacyAuthContainer({ auth: framework.modules.auth });

await authContainer.handleWindowCallbackAsync();

const telemetryLogger = new TelemetryLogger(telemetry?.instrumentationKey ?? '', authContainer);
  1. create-service-resolver.ts
    • Changed the third parameter of authContainer.registerAppAsync from false to true.
return authContainer.registerAppAsync(
    id,
    uris.map((x) => x.uri),
    true,
);

Copy link

changeset-bot bot commented Nov 14, 2024

🦋 Changeset detected

Latest commit: 18d0634

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@equinor/fusion-framework-legacy-interopt Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 🐞 bug Something isn't working 👾 React 🚀 feature New feature or request labels Nov 14, 2024
@eikeland eikeland force-pushed the fix/legacy-interopt/token-from-url branch from 7e3be8b to 18387fb Compare November 14, 2024 09:59
@eikeland eikeland force-pushed the fix/legacy-interopt/token-from-url branch from 18387fb to 18d0634 Compare November 14, 2024 10:01
@eikeland eikeland self-assigned this Nov 14, 2024
@eikeland eikeland marked this pull request as ready for review November 14, 2024 10:16
@eikeland eikeland requested review from odinr and a team as code owners November 14, 2024 10:16
Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 0.39% 1746 / 445438
🔵 Statements 0.39% 1746 / 445438
🔵 Functions 22.96% 203 / 884
🔵 Branches 37.1% 384 / 1035
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/react/legacy-interopt/src/LegacyAuthContainer.ts 0% 0% 0% 0% 1-154
Generated in workflow #8019 for commit 18d0634 by the Vitest Coverage Report Action

@eikeland eikeland merged commit 2e1a4fd into main Nov 14, 2024
10 checks passed
@eikeland eikeland deleted the fix/legacy-interopt/token-from-url branch November 14, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 🚀 feature New feature or request 👾 React
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants